Page MenuHomePhabricator
Differential D6084

[4/n] Remove mode_def from SystemExecutionContext, replace with mode_name
AbandonedPublic
Actions

Authored by dgibson on Jan 21 2021, 4:35 PM.

Details

Reviewers
alangenfeld
Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
rmpipelinedef4
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dgibson created this revision.Jan 21 2021, 4:35 PM
dgibson updated this revision to Diff 30001.Jan 21 2021, 4:59 PM

up

dgibson updated this revision to Diff 30004.Jan 21 2021, 5:37 PM

up

Harbormaster failed remote builds in B24634: Diff 29997!Jan 21 2021, 5:41 PM
Harbormaster completed remote builds in B24641: Diff 30004.Jan 21 2021, 5:57 PM
dgibson requested review of this revision.Jan 21 2021, 5:57 PM
Harbormaster failed remote builds in B24638: Diff 30001!Jan 21 2021, 6:07 PM
dgibson retitled this revision from Remove mode_def from SystemExecutionContext, replace with mode_name to [4/n] Remove mode_def from SystemExecutionContext, replace with mode_name.Jan 22 2021, 3:37 PM
dgibson added a reviewer: alangenfeld.
alangenfeld accepted this revision.Jan 22 2021, 4:40 PM
This revision is now accepted and ready to land.Jan 22 2021, 4:40 PM
dgibson abandoned this revision.Tue, Feb 9, 8:09 PM

putting on ice for now

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
execution/
context/
22 lines
1 line
libraries/
dagster-dask/
dagster_dask/
2 lines

Diff 30004

View Options

python_modules/dagster/dagster/core/execution/context/system.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/context_creation_pipeline.py

Loading...
View Options

python_modules/libraries/dagster-dask/dagster_dask/executor.py

Loading...