Page MenuHomePhabricator

Remove pipeline_def from top-level SystemExecutionContext, only use in step execution contexts
ClosedPublic

Authored by dgibson on Jan 21 2021, 3:05 PM.

Details

Summary

Small baby-step towards being able to run the run worker without having access to the underlying PipelineDefinition / user code. The callsites requiring the pipeline_def from the pipeline exeuction context were just using it to get the pipeline name for events, which can be found from lots of other places (including the pipeline run)

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 3:25 PM
Harbormaster failed remote builds in B24627: Diff 29990!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 3:46 PM
Harbormaster failed remote builds in B24628: Diff 29991!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 21 2021, 4:52 PM
Harbormaster failed remote builds in B24633: Diff 29996!

solids still have access to context.pipeline_def right? just making sure this isnt a breaking change

This revision is now accepted and ready to land.Jan 21 2021, 6:05 PM
python_modules/dagster/dagster/core/execution/context/system.py
295

solids still have it available here, yeah