Page MenuHomePhabricator

[dagit] Granular lodash imports
ClosedPublic

Authored by dish on Jan 20 2021, 10:38 PM.

Details

Summary

Change lodash imports to use individual lodash features, reducing the vendor bundle size a bit further.

File sizes after gzip:

Before (D6072):

  596.68 KB  build/static/js/2.98ac1f77.chunk.js
  143.01 KB  build/static/js/main.0f2746db.chunk.js
  72.93 KB   build/static/js/3.a76ca228.chunk.js
  32.28 KB   build/922792c33f2e681c1472.worker.js
  31.38 KB   build/static/css/2.bc62a557.chunk.css
  14.61 KB   build/static/js/4.cacb1563.chunk.js
  2.93 KB    build/static/css/3.4439d99d.chunk.css
  1.48 KB    build/static/js/runtime-main.efbdbfc2.js
  326 B      build/static/css/main.af0c7fcc.chunk.css

After:

  574.81 KB (-21.87 KB)  build/static/js/2.93758a31.chunk.js
  143.03 KB (+18 B)      build/static/js/main.bd81df91.chunk.js
  72.92 KB (-4 B)        build/static/js/3.99bf0117.chunk.js
  32.28 KB               build/922792c33f2e681c1472.worker.js
  31.38 KB               build/static/css/2.bc62a557.chunk.css
  14.6 KB (-2 B)         build/static/js/4.1dc833e5.chunk.js
  2.93 KB                build/static/css/3.4439d99d.chunk.css
  1.48 KB (+2 B)         build/static/js/runtime-main.55fc6b24.js
  326 B                  build/static/css/main.af0c7fcc.chunk.css
Test Plan

Buildkite

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.