Page MenuHomePhabricator

[1/2] Fix Helm templating for env, envConfigMaps, and envSecrets
ClosedPublic

Authored by rexledesma on Jan 20 2021, 5:50 PM.

Details

Summary

After adding the Helm schema for these fields, the templating logic was
not updated. Here, we address that.

For some Helm values (e.g. dagit.env), the schema is still not present.
A subsequent diff will add those schemas.

Test Plan

helm template with fields filled out
helm install --dry-run errors out if fields are malformed
integration

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rexledesma edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 20 2021, 6:55 PM
Harbormaster failed remote builds in B24590: Diff 29945!
Harbormaster failed remote builds in B24589: Diff 29944!

add fields to Helm values in integration tests

This revision is now accepted and ready to land.Jan 21 2021, 9:08 PM