Page MenuHomePhabricator

(#1548) Fix Dask + composites
ClosedPublic

Authored by natekupp on Jul 12 2019, 6:07 PM.

Details

Summary

We previously were mashing foo.bar into a single SolidHandle; this changes that logic to build up the stack of solid handles for foo and bar that get_solid expects

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

natekupp created this revision.Jul 12 2019, 6:07 PM
natekupp edited the summary of this revision. (Show Details)Jul 12 2019, 6:17 PM
natekupp added reviewers: schrockn, alangenfeld, max, sashank.
natekupp edited the summary of this revision. (Show Details)
schrockn requested changes to this revision.Jul 12 2019, 6:26 PM
schrockn added inline comments.
python_modules/dagster-dask/dagster_dask_tests/test_execute.py
25

let's create a deeply nested composite with a bit of fan out to exercise this more. would be nice to have a little utility that does this easily.

python_modules/dagster-graphql/dagster_graphql/util.py
301

let's create task about creating a properly structured graphql response so that client's don't have to this parsing. leave a comment here with issue # so we can grep for it

This revision now requires changes to proceed.Jul 12 2019, 6:26 PM
natekupp updated this revision to Diff 2852.Jul 12 2019, 9:41 PM

comments

max accepted this revision.Jul 12 2019, 10:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2019, 10:18 PM
This revision was automatically updated to reflect the committed changes.