Page MenuHomePhabricator

[mypy][core] definitions/decorators/composite_solid.py mypy
ClosedPublic

Authored by cdecarolis on Jan 20 2021, 4:22 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 20 2021, 4:42 PM
Harbormaster failed remote builds in B24574: Diff 29927!
python_modules/dagster/dagster/core/definitions/decorators/composite_solid.py
33

Would it make sense to annotate the parameters and return types of this Callable?

python_modules/dagster/dagster/core/definitions/decorators/composite_solid.py
72–78

Does this function actually accept an empty set of inputs?

python_modules/dagster/dagster/core/definitions/decorators/composite_solid.py
33

I'm not sure if it makes sense here, because there aren't any restrictions on inputs/outputs to the decorated fxn I believe.

72–78

Hm I guess it would be more accurate to say it accepts arbitrary inputs, so I'll change to ellipsis

should be good after the ... changes

This revision is now accepted and ready to land.Jan 21 2021, 12:04 AM
python_modules/dagster/dagster/core/definitions/decorators/composite_solid.py
72–78

so I'll change to ellipsis

same for above as well i think