8/ Miscellaneous Dagstermill cleanup
AbandonedPublic
Actions

Authored by max on Jan 19 2021, 10:26 PM.

Details

Reviewers

sandyryza
yuhan

Summary

Last prep for deprecation/backcompat

Test Plan

Unit

Diff Detail

Repository

R1 dagster

Branch

dagstermill-file-handling

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

Harbormaster failed remote builds in B24548: Diff 29893!Jan 19 2021, 10:45 PM

Harbormaster completed remote builds in B24549: Diff 29894.

max requested review of this revision.Jan 19 2021, 10:46 PM

yuhan added inline comments.Jan 19 2021, 11:54 PM

python_modules/libraries/dagstermill/dagstermill/manager.py
311	are we deprecating this public method here? - shall we throw a deprecation warning and wrap a new `_load_parameter` to be called internally?

max abandoned this revision.Jan 20 2021, 12:31 AM

Revision Contents
Changeset List

Path

Size

python_modules/

libraries/

dagstermill/

engine.py

5 lines

manager.py

79 lines

Diff 29894

View Options

python_modules/libraries/dagstermill/dagstermill/engine.py