Page MenuHomePhabricator

Unpin alembic
ClosedPublic

Authored by dgibson on Jan 19 2021, 6:26 PM.

Details

Summary

Based on the suggestion here: https://github.com/sqlalchemy/alembic/issues/782 (always pass in an engine, not just a connection)

Also stop using a deprecated type param that was removed

Test Plan

BK

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 19 2021, 6:45 PM
Harbormaster failed remote builds in B24530: Diff 29870!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 19 2021, 9:28 PM
Harbormaster failed remote builds in B24542: Diff 29886!
dgibson edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 19 2021, 9:42 PM
This revision was automatically updated to reflect the committed changes.