Page MenuHomePhabricator

Default user deployment replica count to 1
ClosedPublic

Authored by rexledesma on Jan 19 2021, 5:04 PM.

Details

Summary

Resolves https://github.com/dagster-io/dagster/issues/3546.

Since userDeployments.deployments is a list,
when it is overriden, the helm defaults are
not persisted. As a result, any overrides must
fully meet the json schema.

Since replicaCount usually defaults to 1 on
most cases, we make it optional, and set the
default during templating.

Test Plan

N/A

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

remove replicaCount from deployments schema and default to 1

rexledesma retitled this revision from Add user deployment replica count to k8s docs to Default user deployment replica count to 1.Jan 19 2021, 5:20 PM
rexledesma edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 19 2021, 5:34 PM