Page MenuHomeElementl

Remove dev-requirements.txt files
ClosedPublic

Authored by nate on Jan 15 2021, 10:39 PM.

Details

Summary

Remove dev-requirements.txt files in favor of "test" extras_require.

We still had various mixtures of requirements.txt, dev-requirements.txt, and setup.py dependency constraints scattered across the codebase. This diff adopts the convention that all test requirements are specified under the test key of extras_require for our packages, so that you can look at a single file and see all dependencies for a package.

I also updated the dagster package creation template to not create requirements files anymore.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 15 2021, 10:48 PM
Harbormaster failed remote builds in B24505: Diff 29843!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 15 2021, 11:15 PM
Harbormaster failed remote builds in B24507: Diff 29845!
This revision is now accepted and ready to land.Jan 19 2021, 7:36 PM
.buildkite/dagster-buildkite/dagster_buildkite/steps/dagit.py
7

this is pretty nit

examples/airline_demo/setup.py
1

Why is this directive needed?

.buildkite/dagster-buildkite/dagster_buildkite/steps/dagit.py
7

ah its actually List[dict]

7

ah this is actually List[dict] not List[StepBuilder] which is a good argument for including the type

examples/airline_demo/setup.py
1

otherwise I get error:

Skipping analyzing 'setuptools': found module but no type hints or library stubsmypy(error)

see: https://github.com/pypa/setuptools/issues/2345

This revision was automatically updated to reflect the committed changes.