Page MenuHomePhabricator

[mypy][core] execution/context
ClosedPublic

Authored by alangenfeld on Jan 15 2021, 5:15 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

python_modules/dagster/dagster/core/execution/context/compute.py
76

Should this be Any? Someone could do

@solid(config_schema=str) 
def my_solid(_):
    ...
python_modules/dagster/dagster/core/execution/context/init.py
41

Dict[str, Any]?

python_modules/dagster/dagster/core/execution/context/step.py
36

Optional?

python_modules/dagster/dagster/core/execution/context/system.py
299

This is a NamedTuple elsewhere? Should it be consistent?

rexledesma added inline comments.
python_modules/dagster/dagster/core/execution/context/init.py
40
python_modules/dagster/dagster/core/execution/context/step.py
32

Is there a more specific type?

python_modules/dagster/dagster/core/execution/context/system.py
30–35

Why are these only imported during type checking?

422–423

Update

423–424

Use this type?

nice thanks for the close review, will address inlines

ya the ..._config fields all should be Any

python_modules/dagster/dagster/core/execution/context/system.py
30–35

circular dependencies

python_modules/dagster/dagster/core/execution/context/init.py
40

how does it not error out on this

python_modules/dagster/dagster/core/execution/context/step.py
32

the keys of the tuple are a function of the solid being executeds required resource keys

This revision is now accepted and ready to land.Jan 15 2021, 8:44 PM
This revision was automatically updated to reflect the committed changes.