Page MenuHomePhabricator
Differential D6020

[mypy][core] execution api.py and active.py
ClosedPublic
Actions

Authored by alangenfeld on Jan 14 2021, 11:51 PM.

Details

Reviewers
max
cdecarolis
sandyryza
Commits
R1:9184970fc2e6: [mypy][core] execution api.py and active.py
Test Plan

mypy

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld created this revision.Jan 14 2021, 11:51 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 15 2021, 12:08 AM
Harbormaster failed remote builds in B24471: Diff 29794!
alangenfeld updated this revision to Diff 29800.Jan 15 2021, 12:12 AM

fixes

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 15 2021, 12:30 AM
Harbormaster failed remote builds in B24476: Diff 29800!
alangenfeld updated this revision to Diff 29816.Jan 15 2021, 3:28 PM

rm accident tuple

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 15 2021, 3:49 PM
Harbormaster failed remote builds in B24488: Diff 29816!
alangenfeld updated this revision to Diff 29822.Jan 15 2021, 4:10 PM

cancel change

Harbormaster completed remote builds in B24493: Diff 29822.Jan 15 2021, 4:29 PM
alangenfeld requested review of this revision.Jan 15 2021, 4:29 PM
sandyryza added a comment.Jan 15 2021, 4:34 PM

Hell yeah!

sandyryza accepted this revision.Jan 15 2021, 4:34 PM
This revision is now accepted and ready to land.Jan 15 2021, 4:34 PM
Closed by commit R1:9184970fc2e6: [mypy][core] execution api.py and active.py (authored by alangenfeld). · Explain WhyJan 15 2021, 7:16 PM
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:9184970fc2e6: [mypy][core] execution api.py and active.py.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
24 lines
execution/
155 lines
plan/
111 lines
utils/
4 lines
dagster_tests/
core_tests/
execution_tests/
6 lines

Diff 29835

View Options

python_modules/dagster/dagster/core/definitions/pipeline_base.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/api.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/plan/active.py

Loading...
View Options

python_modules/dagster/dagster/utils/merger.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_api_iterators.py

Loading...