Differential D6008

Revert "Deprecate FileManager and FileHandle #3535"
ClosedPublic
Actions

Authored by max on Jan 14 2021, 8:23 PM.

Tags

None

Subscribers

None

Details

Reviewers

sandyryza
yuhan

Commits

R1:03883d6d98c9: Revert "Deprecate FileManager and FileHandle #3535"

Summary

This reverts commit 54fcccbb0ae41f03883a14636924c8f34a0ceb9c. Delay deprecation to 0.10.1 to ensure that unfixable deprecation warnings are not thrown when people use the output_notebook machinery in Dagstermill. See https://github.com/dagster-io/dagster/issues/3535

Test Plan

Unit

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Jan 14 2021, 8:23 PM

Harbormaster completed remote builds in B24442: Diff 29751.Jan 14 2021, 8:42 PM

max requested review of this revision.Jan 14 2021, 8:42 PM

yuhan accepted this revision.Jan 14 2021, 8:42 PM

This revision is now accepted and ready to land.Jan 14 2021, 8:42 PM

Closed by commit R1:03883d6d98c9: Revert "Deprecate FileManager and FileHandle #3535" (authored by max). · Explain WhyJan 14 2021, 8:45 PM

This revision was automatically updated to reflect the committed changes.

max added a commit: R1:03883d6d98c9: Revert "Deprecate FileManager and FileHandle #3535".

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster/

core/

storage/

file_manager.py

14 lines

libraries/

dagster-aws/

dagster_aws/

s3/

file_manager.py

2 lines

dagster-azure/

dagster_azure/

adls2/

file_manager.py

2 lines

dagster-gcp/

dagster_gcp/

gcs/

file_manager.py

2 lines

Diff 29757

python_modules/dagster/dagster/core/storage/file_manager.py

Loading...

python_modules/libraries/dagster-aws/dagster_aws/s3/file_manager.py

Loading...

python_modules/libraries/dagster-azure/dagster_azure/adls2/file_manager.py

Loading...

python_modules/libraries/dagster-gcp/dagster_gcp/gcs/file_manager.py

Loading...