[dagit] Improve PythonError case in RunGroupPanel
ClosedPublic
Actions

Authored by dish on Jan 14 2021, 6:18 PM.

Details

Reviewers

nate
prha
sashank

Commits

R1:1d530668e8cf: [dagit] Improve PythonError case in RunGroupPanel

Summary

Clean up the PythonError case in RunGroupPanel, which is currently just some text jammed into the UI.

Test Plan

Force error codepath, verify proper rendering and error dialog behavior.

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish created this revision.Jan 14 2021, 6:18 PM

Before:

After:

Harbormaster completed remote builds in B24414: Diff 29716.Jan 14 2021, 6:23 PM

dish requested review of this revision.Jan 14 2021, 6:23 PM

sashank accepted this revision.Jan 14 2021, 6:50 PM

This revision is now accepted and ready to land.Jan 14 2021, 6:50 PM

Closed by commit R1:1d530668e8cf: [dagit] Improve PythonError case in RunGroupPanel (authored by dish). · Explain WhyJan 15 2021, 6:02 PM

This revision was automatically updated to reflect the committed changes.

dish added a commit: R1:1d530668e8cf: [dagit] Improve PythonError case in RunGroupPanel.

dish added inline comments.Jan 15 2021, 7:04 PM

js_modules/dagit/src/gantt/RunGroupPanel.tsx
53

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

src/

gantt/

RunGroupPanel.tsx

32 lines

Diff 29828

View Options

js_modules/dagit/src/gantt/RunGroupPanel.tsx

[dagit] Improve PythonError case in RunGroupPanelClosedPublicActions