Page MenuHomePhabricator

handle latest version of nbformat, which adds random string ids
ClosedPublic

Authored by prha on Jan 14 2021, 6:02 PM.

Details

Summary

https://github.com/jupyter/nbformat/issues/196 does not affect this test, since it just
maintains version behavior for existing notebooks, rather than instantiating new cells. This
diff just changes the assertion check, by explicitly setting the minor version to 5, and by
using a regex to handle the newly inserted random ids.

Test Plan

ran test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.