Page MenuHomePhabricator
Differential D5996

only connect on init when needed
ClosedPublic
Actions

Authored by alangenfeld on Thu, Jan 14, 4:03 PM.

Details

Reviewers
dgibson
Commits
R1:b14a5d08d927: only connect on init when needed
Summary

nit pick feedback on D5982,

this connect call has a cost (depending on network distance to DBs), at least in the non-dagit code paths when pooling isn't on so only do it when needed

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-postgres/
dagster_postgres/
event_log/
6 lines
run_storage/
8 lines
schedule_storage/
7 lines

Diff 29699

View Options

python_modules/libraries/dagster-postgres/dagster_postgres/event_log/event_log.py

Loading...
View Options

python_modules/libraries/dagster-postgres/dagster_postgres/run_storage/run_storage.py

Loading...
View Options

python_modules/libraries/dagster-postgres/dagster_postgres/schedule_storage/schedule_storage.py

Loading...