Make instance migration error clearer
ClosedPublic
Actions

Authored by dgibson on Thu, Jan 14, 2:55 AM.

Details

Reviewers

nate
schrockn
alangenfeld
prha

Commits

R1:b229d3dfffdb: Make instance migration error clearer

Summary

Exception chaining is producing this monstrosity: https://dagster.phacility.com/P145

with the important bit (that you need to migrate) in the middle of a gross SQL sandwich.

Disabling exception chaining gives us this instead, which is IMO much clearer: https://dagster.phacility.com/P146

Test Plan

migrate from 0.9.0 to 0.10.0, bask in the clarity of the new error message

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dgibson created this revision.Thu, Jan 14, 2:55 AM

dgibson published this revision for review.Thu, Jan 14, 2:55 AM

Harbormaster failed remote builds in B24361: Diff 29651!Thu, Jan 14, 3:14 AM

victreebel

python_modules/dagster/dagster/core/storage/sql.py
67	`includd`

This revision is now accepted and ready to land.Thu, Jan 14, 3:30 PM

Harbormaster completed remote builds in B24386: Diff 29678.Thu, Jan 14, 3:31 PM

Harbormaster completed remote builds in B24390: Diff 29684.Thu, Jan 14, 4:00 PM

Closed by commit R1:b229d3dfffdb: Make instance migration error clearer (authored by dgibson). · Explain WhyThu, Jan 14, 4:42 PM

This revision was automatically updated to reflect the committed changes.

dgibson added a commit: R1:b229d3dfffdb: Make instance migration error clearer.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

storage/

sql.py

5 lines

Diff 29701

View Options

python_modules/dagster/dagster/core/storage/sql.py

Make instance migration error clearerClosedPublicActions