Page MenuHomePhabricator
Differential D5986

Add mailing list subscription button (via Revue)
ClosedPublic
Actions

Authored by catherinewu on Jan 13 2021, 11:49 PM.

Details

Reviewers
yuhan
Commits
R1:3d5076a71ca1: Add mailing list subscription button (via Revue)
Summary

Add mailing list subscription button.

I briefly evaluated Revue and Mailchimp. Revue seemed more aesthetic and easy to use. Also, see https://www.getrevue.co/profile/dagster vs http://eepurl.com/hnYH7r. It's easy to switch between providers later on so just going to go with Revue

Open to using a different icon

Test Plan

previewed docs locally

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

catherinewu created this revision.Jan 13 2021, 11:49 PM
catherinewu retitled this revision from add link to subscribe to revue to Add mailing list subscription button (via Revue).Jan 13 2021, 11:51 PM
catherinewu edited the summary of this revision. (Show Details)
rexledesma added a subscriber: rexledesma.Jan 14 2021, 12:07 AM

Can you link a screenshot preview?

docs/next/src/components/CommunityLinks.tsx
37

why h-7?

Harbormaster completed remote builds in B24339: Diff 29621.Jan 14 2021, 12:09 AM
catherinewu requested review of this revision.Jan 14 2021, 12:09 AM
catherinewu updated this revision to Diff 29642.Jan 14 2021, 1:26 AM

up

Harbormaster failed remote builds in B24355: Diff 29642!Jan 14 2021, 1:42 AM
catherinewu added a comment.Jan 14 2021, 2:30 AM

Screen Shot 2021-01-13 at 3.51.30 PM.png (1×3 px, 717 KB)

docs/next/src/components/CommunityLinks.tsx
37

the stackoverflow icon is smaller than the others

catherinewu updated this revision to Diff 29765.Jan 14 2021, 9:24 PM

rebase

catherinewu updated this revision to Diff 29766.Jan 14 2021, 9:26 PM

update license

catherinewu added a reviewer: yuhan.Jan 14 2021, 9:26 PM
yuhan accepted this revision.Jan 14 2021, 9:35 PM
This revision is now accepted and ready to land.Jan 14 2021, 9:35 PM
Harbormaster completed remote builds in B24451: Diff 29765.Jan 14 2021, 9:43 PM
Harbormaster completed remote builds in B24452: Diff 29766.Jan 14 2021, 9:46 PM
Closed by commit R1:3d5076a71ca1: Add mailing list subscription button (via Revue) (authored by catherinewu). · Explain WhyJan 14 2021, 9:49 PM
This revision was automatically updated to reflect the committed changes.
catherinewu added a commit: R1:3d5076a71ca1: Add mailing list subscription button (via Revue).

Revision Contents
Changeset List

PathSize
docs/
next/
public/
assets/
images/
logos/
1 line
src/
components/
13 lines

Diff 29773

View Options

docs/next/public/assets/images/logos/email-icon.svg

Loading...
View Options

docs/next/src/components/CommunityLinks.tsx

Loading...