Page MenuHomePhabricator
Differential D5985

fix tick history panning, tooltip width
ClosedPublic
Actions

Authored by prha on Jan 13 2021, 11:09 PM.

Details

Reviewers
dgibson
dish
Commits
R1:d87728fb178e: fix tick history panning, tooltip width
Summary

set a max length for tooltip message, set the persistent bounds on panning action

Test Plan

panned tick history, saw snipped tooltips

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha created this revision.Jan 13 2021, 11:09 PM
Harbormaster completed remote builds in B24335: Diff 29615.Jan 13 2021, 11:18 PM
prha requested review of this revision.Jan 13 2021, 11:18 PM
dgibson accepted this revision.Jan 14 2021, 1:50 AM
This revision is now accepted and ready to land.Jan 14 2021, 1:50 AM
dish added a comment.Jan 14 2021, 2:37 PM

Could the text wrap instead of being truncated?

prha added a comment.Jan 14 2021, 4:04 PM

Not without custom tooltips, which I'm looking into but is a lot for right now.

Closed by commit R1:d87728fb178e: fix tick history panning, tooltip width (authored by prha). · Explain WhyJan 14 2021, 4:05 PM
This revision was automatically updated to reflect the committed changes.
prha added a commit: R1:d87728fb178e: fix tick history panning, tooltip width.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
src/
jobs/
14 lines

Diff 29689

View Options

js_modules/dagit/src/jobs/TickHistory.tsx

Loading...