Page MenuHomePhabricator
Differential D5970

4/ Clarify return types and interfaces
ClosedPublic
Actions

Authored by max on Wed, Jan 13, 7:51 PM.

Details

Reviewers
sandyryza
yuhan
Commits
R1:4f5f41ec9823: 4/ Clarify return types and interfaces
Summary

Housekeeping

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Wed, Jan 13, 7:51 PM
Harbormaster completed remote builds in B24296: Diff 29557.Wed, Jan 13, 8:09 PM
max requested review of this revision.Wed, Jan 13, 8:09 PM
yuhan accepted this revision.Wed, Jan 13, 9:06 PM
This revision is now accepted and ready to land.Wed, Jan 13, 9:06 PM
sandyryza accepted this revision.Wed, Jan 13, 9:11 PM

I love it.

python_modules/dagster/dagster/core/execution/context/compute.py
43

This will be a ScopedResources object. ScopedResources is a type that's generated inside a function, so doesn't make sense to include annotate here, but something we could do is:

  • Define an interface that the generated ScopedResource classes extend
  • Include some documentation on that interface
  • Mark that interface as the return type here
max added inline comments.Wed, Jan 13, 9:16 PM
python_modules/dagster/dagster/core/execution/context/compute.py
43

yeah that'd be helpful at some point -- i'll open an issue -- i think to do it right might involve a fair amount of typing magic

Closed by commit R1:4f5f41ec9823: 4/ Clarify return types and interfaces (authored by max). · Explain WhyWed, Jan 13, 9:16 PM
This revision was automatically updated to reflect the committed changes.
max added a commit: R1:4f5f41ec9823: 4/ Clarify return types and interfaces.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
execution/
context/
14 lines
2 lines
2 lines
utils/
5 lines

Diff 29585

View Options

python_modules/dagster/dagster/core/execution/context/compute.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/context/step.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/context/system.py

Loading...
View Options

python_modules/dagster/dagster/utils/__init__.py

Loading...