Page MenuHomePhabricator
Differential D5967

improve IO manager docstrings
ClosedPublic
Actions

Authored by sandyryza on Wed, Jan 13, 7:37 PM.

Details

Reviewers
max
yuhan
Commits
R1:b51b3ae5d3ae: improve IO manager docstrings
Summary

improve apidoc for IOManagers and RootInputManagers

Test Plan

manual inspection

Diff Detail

Repository
R1 dagster
Branch
io-manager-docstring (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sandyryza created this revision.Wed, Jan 13, 7:37 PM
Harbormaster completed remote builds in B24292: Diff 29553.Wed, Jan 13, 7:58 PM
sandyryza requested review of this revision.Wed, Jan 13, 7:58 PM
yuhan resigned from this revision.Wed, Jan 13, 9:14 PM

lg2m. will let max sign off

python_modules/dagster/dagster/core/storage/root_input_manager.py
70

make sure we test this link is working:

:py:func:`@root_input_manager <root_input_manager>`
sandyryza updated this revision to Diff 29598.Wed, Jan 13, 10:14 PM

up

sandyryza updated this revision to Diff 29599.Wed, Jan 13, 10:15 PM

up

sandyryza added a child revision: D5980: mark root input managers as experimental.Wed, Jan 13, 10:17 PM
Harbormaster completed remote builds in B24321: Diff 29598.Wed, Jan 13, 10:33 PM
Harbormaster completed remote builds in B24322: Diff 29599.
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 13, 11:56 PM
Closed by commit R1:b51b3ae5d3ae: improve IO manager docstrings (authored by sandyryza). · Explain Why
This revision was automatically updated to reflect the committed changes.
sandyryza added a commit: R1:b51b3ae5d3ae: improve IO manager docstrings.

Revision Contents
Changeset List

PathSize
docs/
sections/
api/
apidocs/
7 lines
python_modules/
dagster/
dagster/
core/
definitions/
4 lines
execution/
context/
6 lines
storage/
18 lines
42 lines
4 lines
19 lines

Diff 29599

View Options

docs/sections/api/apidocs/io-managers.rst

Loading...
View Options

python_modules/dagster/dagster/core/definitions/input.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/context/system.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/input_manager.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/io_manager.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/output_manager.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/root_input_manager.py

Loading...