Fix build failure from six cleanup
ClosedPublic
Actions

Authored by nate on Wed, Jan 13, 6:19 PM.

Details

Reviewers

Commits

R1:990e59065144: Fix build failure from six cleanup

Summary

k8s API actually returns binary string, but our mock was returning regular string - this makes the mock consistent w/ the k8s API, and re-runs w/ integration tests also

Test Plan

integration

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Wed, Jan 13, 6:19 PM

nate retitled this revision from Fix six build failure to Fix build failure from six cleanup.Wed, Jan 13, 6:33 PM

nate edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B24263: Diff 29520!Wed, Jan 13, 6:37 PM

nate published this revision for review.Wed, Jan 13, 6:37 PM

alangenfeld accepted this revision.Wed, Jan 13, 6:43 PM

This revision is now accepted and ready to land.Wed, Jan 13, 6:43 PM

Harbormaster failed remote builds in B24266: Diff 29524!Wed, Jan 13, 6:51 PM

This revision was landed with ongoing or failed builds.Wed, Jan 13, 6:58 PM

Closed by commit R1:990e59065144: Fix build failure from six cleanup (authored by nate). · Explain Why

This revision was automatically updated to reflect the committed changes.

nate added a commit: R1:990e59065144: Fix build failure from six cleanup.

Harbormaster completed remote builds in B24269: Diff 29528.Wed, Jan 13, 6:58 PM

Revision Contents
Changeset List

Path

Size

python_modules/

libraries/

dagster-k8s/

dagster_k8s/

client.py

9 lines

dagster_k8s_tests/

unit_tests/

test_client.py

2 lines

Diff 29540

View Options

python_modules/libraries/dagster-k8s/dagster_k8s/client.py