Page MenuHomePhabricator

Move not_graphql_context_test_suite to root tox file
ClosedPublic

Authored by sashank on Wed, Jan 13, 5:03 PM.

Details

Summary

Previously, all the tests that were not part of the dagster-graphql context test matrix were included in the postgres_tox.ini file and run as a part of the dagster-graphql-postgres BK step. This was due to one test: test_readonly_variants, which had a dagster_postgres dependency.

This diff updates the tox files to run all tests not part of the test matrix as a part of the dagster-graphql step, and adds a variant mark that only tests the test_readonly_variants in the dagster-graphql-postgres step.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank created this revision.

forgot a file

sashank edited the summary of this revision. (Show Details)

up

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 13, 5:35 PM
Harbormaster failed remote builds in B24251: Diff 29503!
Harbormaster failed remote builds in B24253: Diff 29505!
alangenfeld added inline comments.
.buildkite/dagster-buildkite/dagster_buildkite/steps/dagster.py
296

i dont really know what variant is supposed to mean on its own, maybe a slightly more descriptive name ?

This revision is now accepted and ready to land.Wed, Jan 13, 7:21 PM

update name of "variants" mark