Page MenuHomePhabricator
Differential D5956

Move not_graphql_context_test_suite to root tox file
ClosedPublic
Actions

Authored by sashank on Wed, Jan 13, 5:03 PM.

Details

Reviewers
dgibson
alangenfeld
Commits
R1:9bb8189a1483: Move not_graphql_context_test_suite to root tox file
Summary

Previously, all the tests that were not part of the dagster-graphql context test matrix were included in the postgres_tox.ini file and run as a part of the dagster-graphql-postgres BK step. This was due to one test: test_readonly_variants, which had a dagster_postgres dependency.

This diff updates the tox files to run all tests not part of the test matrix as a part of the dagster-graphql step, and adds a variant mark that only tests the test_readonly_variants in the dagster-graphql-postgres step.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

sashank updated this revision to Diff 29497.Wed, Jan 13, 5:03 PM
sashank created this revision.

forgot a file

sashank updated this revision to Diff 29501.Wed, Jan 13, 5:15 PM

up

sashank edited the summary of this revision. (Show Details)Wed, Jan 13, 5:17 PM
sashank updated this revision to Diff 29503.Wed, Jan 13, 5:18 PM
sashank edited the summary of this revision. (Show Details)

up

sashank updated this revision to Diff 29505.Wed, Jan 13, 5:19 PM

move to branch

Harbormaster failed remote builds in B24244: Diff 29496!Wed, Jan 13, 5:20 PM
sashank added a child revision: D5953: Split DagterGraphQLContext into ProcessContext and RequestContext.Wed, Jan 13, 5:20 PM
Harbormaster failed remote builds in B24245: Diff 29497!Wed, Jan 13, 5:23 PM
Harbormaster failed remote builds in B24249: Diff 29501!Wed, Jan 13, 5:31 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 13, 5:35 PM
Harbormaster failed remote builds in B24251: Diff 29503!
Harbormaster failed remote builds in B24253: Diff 29505!
sashank updated this revision to Diff 29512.Wed, Jan 13, 5:39 PM

up

Harbormaster completed remote builds in B24258: Diff 29512.Wed, Jan 13, 5:57 PM
sashank requested review of this revision.Wed, Jan 13, 5:57 PM
alangenfeld accepted this revision.Wed, Jan 13, 7:21 PM
alangenfeld added inline comments.
.buildkite/dagster-buildkite/dagster_buildkite/steps/dagster.py
295–296

i dont really know what variant is supposed to mean on its own, maybe a slightly more descriptive name ?

This revision is now accepted and ready to land.Wed, Jan 13, 7:21 PM
sashank updated this revision to Diff 29590.Wed, Jan 13, 9:24 PM

update name of "variants" mark

sashank updated this revision to Diff 29591.Wed, Jan 13, 9:25 PM

up

Harbormaster failed remote builds in B24314: Diff 29590!Wed, Jan 13, 9:42 PM
Harbormaster completed remote builds in B24315: Diff 29591.
Closed by commit R1:9bb8189a1483: Move not_graphql_context_test_suite to root tox file (authored by sashank). · Explain WhyThu, Jan 14, 2:42 PM
This revision was automatically updated to reflect the committed changes.
sashank added a commit: R1:9bb8189a1483: Move not_graphql_context_test_suite to root tox file.

Revision Contents
Changeset List

PathSize
.buildkite/
dagster-buildkite/
dagster_buildkite/
steps/
2 lines
python_modules/
dagster-graphql/
3 lines
1 line

Diff 29497

View Options

.buildkite/dagster-buildkite/dagster_buildkite/steps/dagster.py

Loading...
View Options

python_modules/dagster-graphql/tox.ini

Loading...
View Options

python_modules/dagster-graphql/tox_postgres.ini

Loading...