Page MenuHomePhabricator

[dagit] Use tabular-nums spacing on TimestampDisplay
ClosedPublic

Authored by dish on Jan 13 2021, 4:12 PM.

Details

Summary

Tidy up timestamp string rendering a bit by using tabular-nums. I need to spend some time cleaning these up more generally.

Test Plan

View "Upcoming ticks" table on "All schedules", verify that the timestamp column has consistent text.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

It's a subtle difference, more noticeable when there are a lot of rows with varying timestamp values.

Before:

After:

dish requested review of this revision.Jan 13 2021, 4:18 PM
This revision is now accepted and ready to land.Jan 13 2021, 4:46 PM