Page MenuHomePhabricator

[dagit] Add "Scheduled" tab to Runs page
ClosedPublic

Authored by dish on Jan 13 2021, 3:59 PM.

Details

Summary

Add a visually separated "Scheduled" tab to the "Runs" page, with a list of all scheduled ticks based on the enabled schedules.

I added a new piece to the RunsRootQuery so that we can share the query, poll interval, and refreshable countdown across all of the tabs.

I also included an empty state for the scheduled ticks component.

Test Plan
  • View Runs, verify rendering and behavior of "Scheduled" tab.
  • Click it, verify empty state with no schedules enabled.
  • Enable some schedules, verify that scheduled ticks appear correctly in the "Scheduled" tab.
  • View scheduled ticks on "All schedules" page, verify proper rendering.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish created this revision.

Upcoming -> Scheduled in All Schedules page

dish requested review of this revision.Jan 13 2021, 4:05 PM

could you throw up a screenshot?

Yeah sorry, was cleaning some things up.

Empty state:

Populated state:

Empty state on "All schedules" repo page:

I prefer 'Upcoming' to 'Scheduled', just because they might not be scheduled, and upcoming is just ambiguous enough?

We could also include a SchedulerInfo component somewhere on this tab? Since they're only actually upcoming if the scheduler is up and running?

Oh, interesting. Do you think we need to display something for past ticks that haven't been resolved?

Add (and tweak) SchedulerInfo

can you display pipeline name in addition to schedule name?

This revision now requires changes to proceed.Jan 13 2021, 7:27 PM

Show pipeline name instead of repo, remove YYYY from timestamp format

This revision is now accepted and ready to land.Jan 13 2021, 8:41 PM
This revision was automatically updated to reflect the committed changes.