Use a script to kick off a pipeline run.
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- gql
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
| examples/trigger_pipeline/tests/test_trigger_pipeline.py | ||
|---|---|---|
| 9 | what are some ways that the trigger.py script could break that this test suite is not currently testing? | |
Comment Actions
Add docs content. Add executionMetadata to pipeline run and modify tests
- This is the commit message #5:
| examples/trigger_pipeline/tests/test_trigger_pipeline.py | ||
|---|---|---|
| 9 | May need to check if the workspace is empty and if the file path exists. | |
Comment Actions
Are we exposing or documenting stuff under dagster.core.host_representation like ManagedGrpcPythonEnvRepositoryLocationOrigin, LoadableTargetOrigin, and PipelineSelector, which have been mentioned in this example?
Should we? Without linking to detailed API docs or further explanation, it could be a bit hard for users to digest what's going on when using these suggested APIs. cc @dgibson: as you may have more context in this corner of the codebase.
Besides, I dont think we have documented any of the dagster-graphql apis? Shall we start documenting dagster-graphql? - AFAIK we've been treating it as more of an internal-only package
| docs/next/src/pages/examples/examples.json | ||
|---|---|---|
| 86–110 | plz rebase master and make sure you've picked up the latest changes. i think this has been addressed in D5824 | |
Comment Actions
Yeah, this is fine in that it works but this is not the right way to run a pipeline over GraphQL. The right way to run a pipeline over graphql is to start a dagit server and to query the server.
| examples/trigger_pipeline/trigger_pipeline/trigger.py | ||
|---|---|---|
| 2 | better to have the mutation be explicit | |