Page MenuHomeElementl

Remove usage of six
ClosedPublic

Authored by nate on Jan 12 2021, 11:40 PM.

Details

Summary

Removes all usage of six from the codebase.

Since this involves replacing six.ensure_string and six.ensure_binary, this diff also adopts the convention that we use explicit .decode("utf-8") and .encode("utf-8") everywhere, although I am inclined to change this to bare .decode() and .encode() everywhere since utf-8 is always the default. Thoughts?

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
remove_six
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningscala_modules/scripts/deploy.py:41W0002Print Call
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2021, 11:57 PM
Harbormaster failed remote builds in B24205: Diff 29447!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2021, 12:39 AM
Harbormaster failed remote builds in B24209: Diff 29452!
Harbormaster failed remote builds in B24210: Diff 29453!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2021, 1:18 AM
Harbormaster failed remote builds in B24212: Diff 29455!
alangenfeld added inline comments.
python_modules/libraries/dagstermill/setup.py
35

byebye

This revision is now accepted and ready to land.Jan 13 2021, 4:59 PM
This revision was automatically updated to reflect the committed changes.