Page MenuHomePhabricator

Remove usage of six
ClosedPublic

Authored by nate on Tue, Jan 12, 11:40 PM.

Details

Summary

Removes all usage of six from the codebase.

Since this involves replacing six.ensure_string and six.ensure_binary, this diff also adopts the convention that we use explicit .decode("utf-8") and .encode("utf-8") everywhere, although I am inclined to change this to bare .decode() and .encode() everywhere since utf-8 is always the default. Thoughts?

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jan 12, 11:57 PM
Harbormaster failed remote builds in B24205: Diff 29447!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 13, 12:39 AM
Harbormaster failed remote builds in B24209: Diff 29452!
Harbormaster failed remote builds in B24210: Diff 29453!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 13, 1:18 AM
Harbormaster failed remote builds in B24212: Diff 29455!
nate requested review of this revision.Wed, Jan 13, 1:58 AM
nate added reviewers: alangenfeld, max.
alangenfeld added inline comments.
python_modules/libraries/dagstermill/setup.py
35

byebye

This revision is now accepted and ready to land.Wed, Jan 13, 4:59 PM
This revision was automatically updated to reflect the committed changes.