Page MenuHomePhabricator

deprecate has_configurable_inputs, has_configurable_outputs, and has_config_entry
ClosedPublic

Authored by sandyryza on Tue, Jan 12, 10:32 PM.

Details

Summary

These definition-level properties are deprecated because whether a node has configurable inputs depends on what managers are supplied for its inputs and outputs.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jan 12, 10:50 PM
Harbormaster failed remote builds in B24201: Diff 29440!
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 13, 2:08 AM
Harbormaster failed remote builds in B24220: Diff 29463!

lg2m. had comments about mentioning the version number

python_modules/dagster/dagster/core/definitions/graph.py
285

would be good to mention the version number 0.10.0 here.

python_modules/dagster/dagster/core/definitions/i_solid_definition.py
103

same here

112

same same

python_modules/dagster/dagster/core/definitions/solid.py
113

here

This revision is now accepted and ready to land.Wed, Jan 13, 9:18 PM