Paths

Table of Contentst

py2 cleanup: remove misc uses of future
ClosedPublic
Actions

Authored by nate on Jan 12 2021, 6:31 PM.

Details

Reviewers

alangenfeld
max

Commits

R1:9f8cd25da00e: py2 cleanup: remove misc uses of future

Summary

Can't fully remove yet because snapshottest includes future in its generated files; but this diff removes all non-snapshot uses of future

Test Plan

unit

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nate created this revision.Jan 12 2021, 6:31 PM

Harbormaster completed remote builds in B24163: Diff 29389.Jan 12 2021, 6:49 PM

nate requested review of this revision.Jan 12 2021, 6:49 PM

nate added reviewers: alangenfeld, max.Jan 12 2021, 7:25 PM

nate edited the summary of this revision. (Show Details)

grrrrrrreat

max accepted this revision.Jan 12 2021, 8:03 PM

This revision is now accepted and ready to land.Jan 12 2021, 8:03 PM

Closed by commit R1:9f8cd25da00e: py2 cleanup: remove misc uses of future (authored by nate). · Explain WhyJan 12 2021, 9:23 PM

This revision was automatically updated to reflect the committed changes.

nate added a commit: R1:9f8cd25da00e: py2 cleanup: remove misc uses of future.

Revision Contents
Changeset List

Path

Size

python_modules/

automation/

parse_dataproc_configs.py

2 lines

parse_spark_configs.py

2 lines

dagit/

app.py

2 lines

schema/

__init__.py

2 lines

dagit_tests/

test_smoke.py

2 lines

test_version.py

2 lines

setup.py

2 lines

dagster-graphql/

dagster_graphql/

implementation/

execution/

__init__.py

5 lines

backfill.py

2 lines

launch_execution.py

2 lines

schema/

2 lines

2 lines

2 lines

2 lines

2 lines

dagster/

cli/

2 lines

2 lines

2 lines

2 lines

config/

type_printer.py

2 lines

core/

__init__.py

2 lines

execution/

compute_logs.py

2 lines

poll_compute_logs.py

2 lines

seven/

json.py

2 lines

utils/

indenting_printer.py

2 lines

log.py

2 lines

dagster_tests/

cli_tests/

command_tests/

test_backfill_command.py

2 lines

test_cli_commands.py

2 lines

test_execute_command.py

2 lines

test_launch_command.py

2 lines

test_list_command.py

2 lines

test_print_command.py

2 lines

test_scaffold_command.py

2 lines

test_schedule_commands.py

2 lines

test_sensor_commands.py

2 lines

test_version.py

2 lines

core_tests/

test_log_capture.py

2 lines

test_stdout.py

2 lines

general_tests/

seven_tests/

test_seven.py

4 lines

libraries/

dagster-airflow/

dagster_airflow_tests/

test_factory/

test_python.py

2 lines

dagster-pandas/

dagster_pandas_tests/

test_config_driven_df.py

2 lines

dagster-postgres/

dagster_postgres/

pynotify.py

2 lines

Diff 29428

View Options

python_modules/automation/automation/parse_dataproc_configs.py

View Options

python_modules/automation/automation/parse_spark_configs.py

View Options

python_modules/dagit/dagit/app.py

View Options

python_modules/dagit/dagit/schema/init.py

View Options

python_modules/dagit/dagit_tests/test_smoke.py

View Options

python_modules/dagit/dagit_tests/test_version.py

View Options

python_modules/dagit/setup.py

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/execution/init.py

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/execution/backfill.py

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/execution/launch_execution.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/init.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/execution.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/external.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/runs.py

View Options

python_modules/dagster/dagster/cli/api.py

View Options

python_modules/dagster/dagster/cli/pipeline.py

View Options

python_modules/dagster/dagster/cli/schedule.py

View Options

python_modules/dagster/dagster/cli/sensor.py

View Options

python_modules/dagster/dagster/config/type_printer.py

View Options

python_modules/dagster/dagster/core/init.py

View Options

python_modules/dagster/dagster/core/execution/compute_logs.py

View Options

python_modules/dagster/dagster/core/execution/poll_compute_logs.py

View Options

python_modules/dagster/dagster/seven/json.py

View Options

python_modules/dagster/dagster/utils/indenting_printer.py

View Options

python_modules/dagster/dagster/utils/log.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_backfill_command.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_cli_commands.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_execute_command.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_launch_command.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_list_command.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_print_command.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_scaffold_command.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_schedule_commands.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_sensor_commands.py

View Options

python_modules/dagster/dagster_tests/cli_tests/test_version.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_log_capture.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_stdout.py

View Options

python_modules/dagster/dagster_tests/general_tests/seven_tests/test_seven.py

View Options

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_factory/test_python.py

View Options

python_modules/libraries/dagster-pandas/dagster_pandas_tests/test_config_driven_df.py

View Options

python_modules/libraries/dagster-postgres/dagster_postgres/pynotify.py

py2 cleanup: remove misc uses of futureClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29428

python_modules/automation/automation/parse_dataproc_configs.py

python_modules/automation/automation/parse_spark_configs.py

python_modules/dagit/dagit/app.py

python_modules/dagit/dagit/schema/__init__.py

python_modules/dagit/dagit_tests/test_smoke.py

python_modules/dagit/dagit_tests/test_version.py

python_modules/dagit/setup.py

python_modules/dagster-graphql/dagster_graphql/implementation/execution/__init__.py

python_modules/dagster-graphql/dagster_graphql/implementation/execution/backfill.py

python_modules/dagster-graphql/dagster_graphql/implementation/execution/launch_execution.py

python_modules/dagster-graphql/dagster_graphql/schema/__init__.py

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

python_modules/dagster-graphql/dagster_graphql/schema/execution.py

python_modules/dagster-graphql/dagster_graphql/schema/external.py

python_modules/dagster-graphql/dagster_graphql/schema/runs.py

python_modules/dagster/dagster/cli/api.py

python_modules/dagster/dagster/cli/pipeline.py

python_modules/dagster/dagster/cli/schedule.py

python_modules/dagster/dagster/cli/sensor.py

python_modules/dagster/dagster/config/type_printer.py

python_modules/dagster/dagster/core/__init__.py

python_modules/dagster/dagster/core/execution/compute_logs.py

python_modules/dagster/dagster/core/execution/poll_compute_logs.py

python_modules/dagster/dagster/seven/json.py

python_modules/dagster/dagster/utils/indenting_printer.py

python_modules/dagster/dagster/utils/log.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_backfill_command.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_cli_commands.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_execute_command.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_launch_command.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_list_command.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_print_command.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_scaffold_command.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_schedule_commands.py

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_sensor_commands.py

python_modules/dagster/dagster_tests/cli_tests/test_version.py

python_modules/dagster/dagster_tests/core_tests/test_log_capture.py

python_modules/dagster/dagster_tests/core_tests/test_stdout.py

python_modules/dagster/dagster_tests/general_tests/seven_tests/test_seven.py

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_factory/test_python.py

python_modules/libraries/dagster-pandas/dagster_pandas_tests/test_config_driven_df.py

python_modules/libraries/dagster-postgres/dagster_postgres/pynotify.py

py2 cleanup: remove misc uses of future
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagit/dagit/schema/init.py

python_modules/dagster-graphql/dagster_graphql/implementation/execution/init.py

python_modules/dagster-graphql/dagster_graphql/schema/init.py

python_modules/dagster/dagster/core/init.py