Page MenuHomeElementl
Differential D5928

Remove py2 test skip markers that are now unused
ClosedPublic
Actions

Authored by • nate on Jan 12 2021, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 9, 7:49 PM
Unknown Object (File)
Sun, Jul 31, 9:04 AM
Unknown Object (File)
Thu, Jul 21, 10:35 PM
Unknown Object (File)
Tue, Jul 12, 8:32 PM
Unknown Object (File)
Tue, Jul 12, 6:49 PM
Unknown Object (File)
Jul 12 2022, 4:27 AM
Unknown Object (File)
Jul 11 2022, 12:13 AM
Unknown Object (File)
Jul 10 2022, 10:15 PM
View All 19 Files
Subscribers
None

Details

Reviewers
• max
alangenfeld
Commits
R1:bfcd0482cf7d: Remove py2 test skip markers that are now unused
Summary

Depends on D5927

Test Plan

buildkite

Diff Detail

Repository
R1 dagster
Branch
remove_py2_skips
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• nate created this revision.Jan 12 2021, 5:29 PM
• nate edited the summary of this revision. (Show Details)Jan 12 2021, 5:35 PM
• nate added a parent revision: D5927: Remove misc py2 compat stuff.
• nate updated this revision to Diff 29381.Jan 12 2021, 5:35 PM

up

• nate updated this revision to Diff 29382.Jan 12 2021, 5:43 PM

up

Harbormaster failed remote builds in B24157: Diff 29379!Jan 12 2021, 5:45 PM
Harbormaster failed remote builds in B24159: Diff 29381!Jan 12 2021, 5:52 PM
Harbormaster completed remote builds in B24160: Diff 29382.Jan 12 2021, 6:00 PM
• nate requested review of this revision.Jan 12 2021, 6:00 PM
• nate added reviewers: • max, alangenfeld.Jan 12 2021, 6:28 PM
alangenfeld accepted this revision.Jan 12 2021, 7:22 PM

cleanup

This revision is now accepted and ready to land.Jan 12 2021, 7:22 PM
Closed by commit R1:bfcd0482cf7d: Remove py2 test skip markers that are now unused (authored by • nate). · Explain WhyJan 12 2021, 7:26 PM
This revision was automatically updated to reflect the committed changes.
• nate added a commit: R1:bfcd0482cf7d: Remove py2 test skip markers that are now unused.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql_tests/
graphql/
2 lines
1 line
dagster/
dagster_tests/
api_tests/
1 line
core_tests/
definitions_tests/
29 lines
4 lines
general_tests/
grpc_tests/
1 line
14 lines

Diff 29381

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_graphql_context_test_suite.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_subset.py

Loading...
View Options

python_modules/dagster/dagster_tests/api_tests/test_api_snapshot_pipeline.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_reconstructable.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/test_errors.py

Loading...
View Options

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_compile.py

Loading...
View Options

python_modules/dagster/dagster_tests/general_tests/test_serdes.py

Loading...