Page MenuHomePhabricator

InputManager -> RootInputManager
ClosedPublic

Authored by sandyryza on Tue, Jan 12, 4:21 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jan 12, 4:40 PM
Harbormaster failed remote builds in B24151: Diff 29369!

pidgeot

docs/sections/api/apidocs/io-managers.rst
31–34

update this as well right?

44–45

did this get rm in another diff?

This revision is now accepted and ready to land.Tue, Jan 12, 9:55 PM
docs/sections/api/apidocs/io-managers.rst
31–34

shall we update the wording here too?

python_modules/dagster/dagster/core/storage/root_input_manager.py
110

manager_key -> root_manager_key

docs/sections/api/apidocs/io-managers.rst
44–45

yah

python_modules/dagster/dagster/core/storage/root_input_manager.py
110

thanks for catching

This revision was automatically updated to reflect the committed changes.