Page MenuHomePhabricator

Unify sensor timeline / job history graphs, tick history improvements
ClosedPublic

Authored by prha on Jan 11 2021, 7:48 PM.

Details

Summary
  • Used tabs to unify the "recent" tick view (with live updating bounds) and the tick history view
  • Unified click/hover behavior in both graph views
  • Got rid of the sparse tick table and showed the tick details directly on tick selection
  • Added a reset zoom link
  • Added max zoom bounds, based on the data
  • Added dynamic graph title, based on the zoom range
  • Changed filter buttons into checkboxes
  • Got rid of daemon health overlay on the recent view (redundant with banner)

Test Plan

Viewed schedules / sensors, clicked on failure / success / skip ticks

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

prha requested review of this revision.Jan 11 2021, 7:53 PM
dish added inline comments.
js_modules/dagit/src/jobs/TickHistory.tsx
78

Since there's just one child, this can use Box for the spacing. Same elsewhere too. (The idea with Group is to put spacing in between its children.)

This revision is now accepted and ready to land.Jan 11 2021, 11:43 PM