Page MenuHomePhabricator

[dagit] Repair counts for queued/in-progress run tabs
ClosedPublic

Authored by dish on Jan 11 2021, 6:13 PM.

Details

Summary

Resolves #3525

I was neglecting to include all filters in the count query on Runs, for queued and in-progress counts. Add them.

Test Plan

Start a schedule, filter the "In progress" tab to use that schedule filter. Verify that when a run starts, the count is "1".

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Jan 11 2021, 6:18 PM
js_modules/dagit/src/runs/RunsRoot.tsx
74

What happens when I specify a status in my main filter? Does the second 'statuses' key override the first?

js_modules/dagit/src/runs/RunsRoot.tsx
74

Hm, what do you mean by "main filter" here?

(Discussed in standup -- the statuses key will override ...filter for queuedFilter and inProgressFilter, which should be correct.)

This revision is now accepted and ready to land.Jan 11 2021, 7:09 PM