Page MenuHomePhabricator

[cli] add --run-id to dagster pipeline launch
ClosedPublic

Authored by alangenfeld on Mon, Jan 11, 5:48 PM.

Details

Summary

request from slack

Test Plan

added test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dgibson requested changes to this revision.Mon, Jan 11, 8:08 PM

just a question: Do we do any validation in the DB that the newly created run ID has to be unique? Seems like you can get into a weird state if we don't, and this would open us up to that?

This revision now requires changes to proceed.Mon, Jan 11, 8:08 PM

add test case to show re-use of run_id fails with good error

This revision is now accepted and ready to land.Tue, Jan 12, 4:04 AM