Page MenuHomePhabricator
Differential D5910

[cli] add --run-id to dagster pipeline launch
ClosedPublic
Actions

Authored by alangenfeld on Mon, Jan 11, 5:48 PM.

Details

Reviewers
prha
dgibson
cdecarolis
Commits
R1:c1a670e29004: [cli] add --run-id to dagster pipeline launch
Summary

request from slack

Test Plan

added test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld updated this revision to Diff 29283.Mon, Jan 11, 5:48 PM
alangenfeld created this revision.

assert

alangenfeld updated this revision to Diff 29284.Mon, Jan 11, 5:52 PM

changes.md

Harbormaster completed remote builds in B24081: Diff 29282.Mon, Jan 11, 6:08 PM
Harbormaster completed remote builds in B24083: Diff 29284.
alangenfeld requested review of this revision.Mon, Jan 11, 6:10 PM
Harbormaster completed remote builds in B24082: Diff 29283.Mon, Jan 11, 6:10 PM
dgibson requested changes to this revision.Mon, Jan 11, 8:08 PM

just a question: Do we do any validation in the DB that the newly created run ID has to be unique? Seems like you can get into a weird state if we don't, and this would open us up to that?

This revision now requires changes to proceed.Mon, Jan 11, 8:08 PM
alangenfeld updated this revision to Diff 29316.Mon, Jan 11, 8:34 PM

add test case to show re-use of run_id fails with good error

Harbormaster completed remote builds in B24103: Diff 29316.Mon, Jan 11, 8:53 PM
dgibson accepted this revision.Tue, Jan 12, 4:04 AM
This revision is now accepted and ready to land.Tue, Jan 12, 4:04 AM
Closed by commit R1:c1a670e29004: [cli] add --run-id to dagster pipeline launch (authored by alangenfeld). · Explain WhyTue, Jan 12, 4:42 PM
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:c1a670e29004: [cli] add --run-id to dagster pipeline launch.

Revision Contents
Changeset List

PathSize
1 line
python_modules/
dagster/
dagster/
cli/
7 lines
dagster_tests/
cli_tests/
command_tests/
22 lines

Diff 29373

View Options

CHANGES.md

Loading...
View Options

python_modules/dagster/dagster/cli/pipeline.py

Loading...
View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_launch_command.py

Loading...