Page MenuHomeElementl

Trigger internal repo only for commits from team
ClosedPublic

Authored by nate on Jan 11 2021, 4:38 PM.
Tags
None
Referenced Files
F2561009: D5906.diff
Sat, Sep 24, 3:48 PM
F2560984: D5906.id.diff
Sat, Sep 24, 3:33 PM
F2560956: D5906.id29266.diff
Sat, Sep 24, 3:13 PM
F2560804: D5906.id29268.diff
Sat, Sep 24, 12:47 PM
Unknown Object (File)
Tue, Sep 13, 6:22 AM
Unknown Object (File)
Tue, Sep 13, 6:22 AM
Unknown Object (File)
Tue, Sep 13, 6:22 AM
Unknown Object (File)
Tue, Sep 13, 6:22 AM
Subscribers
None

Details

Test Plan

buildkite

  • tested without build.branch=='master' and build included triggered pipeline
  • tested with build.branch=='master' && build.creator.email =~ /elementl.com$$/ and triggered internal pipeline is skipped
  • will confirm this works with external contributors when landing external PR https://github.com/dagster-io/dagster/pull/3479

Diff Detail

Repository
R1 dagster
Branch
elementl_only
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2021, 4:39 PM
Harbormaster failed remote builds in B24071: Diff 29266!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2021, 4:44 PM
Harbormaster failed remote builds in B24072: Diff 29267!
nate edited the test plan for this revision. (Show Details)
nate added reviewers: bob, rexledesma.
rexledesma added inline comments.
.buildkite/dagster-buildkite/dagster_buildkite/steps/trigger.py
19–20

We should assert this if that's the case (i'm assuming the branch conditional overrides the if)

This revision is now accepted and ready to land.Jan 11 2021, 5:15 PM

yeah buildkite has an assert on their side that fails loudly if both are set, so I figured it'd be best to just fall through to their error message rather than insert our own