Page MenuHomeElementl

Trigger internal repo only for commits from team
ClosedPublic

Authored by nate on Jan 11 2021, 4:38 PM.

Details

Test Plan

buildkite

  • tested without build.branch=='master' and build included triggered pipeline
  • tested with build.branch=='master' && build.creator.email =~ /elementl.com$$/ and triggered internal pipeline is skipped
  • will confirm this works with external contributors when landing external PR https://github.com/dagster-io/dagster/pull/3479

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2021, 4:39 PM
Harbormaster failed remote builds in B24071: Diff 29266!
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2021, 4:44 PM
Harbormaster failed remote builds in B24072: Diff 29267!
nate edited the test plan for this revision. (Show Details)
nate added reviewers: bob, rexledesma.
rexledesma added inline comments.
.buildkite/dagster-buildkite/dagster_buildkite/steps/trigger.py
21–22

We should assert this if that's the case (i'm assuming the branch conditional overrides the if)

This revision is now accepted and ready to land.Jan 11 2021, 5:15 PM

yeah buildkite has an assert on their side that fails loudly if both are set, so I figured it'd be best to just fall through to their error message rather than insert our own