Page MenuHomePhabricator

Update helm defaults for user code deployments, run launcher, and rabbitmq
ClosedPublic

Authored by rexledesma on Sat, Jan 9, 12:43 AM.

Details

Summary

Depends on D5890.

We change the following defaults in the helm chart:

  1. User code deployments are now enabled by default.
  2. The default run launcher is now the K8sRunLauncher.

Thus, we now disable`rabbitmq`, a message broker used
in celery, by default.

Test Plan

helm lint
integration

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Jan 9, 12:58 AM
Harbormaster failed remote builds in B23997: Diff 29180!
helm/dagster/values.yaml
149

Wondering if we can sneak this in as well

helm/dagster/values.yaml
149

ya i think we should move towards this being the default, only bummer is filling out dagsterApiGrpcArgs. We should at least make sure thats documented well if we don't have other means of improving

168–170

do we have any clever ideas for if this can be improved? this is not very user friendly ergonomics wise, though i dont know how to make it better without a lot of complexity

helm/dagster/values.yaml
168–170

We could surface grpc flags as fields to construct the dagster api grpc command, but again that's tying the helm chart to implementation. I'll put up some RFC later on this?

defer to @catherinewu for final accept to make sure docs are aligned

LGTM!

helm/dagster/values.yaml
422

i didnt quite follow why we want to disable rabbitmq by default?

This revision is now accepted and ready to land.Mon, Jan 11, 10:22 PM

oh, we should run integration tests on this

update changes and migration instructions