Paths

Table of Contentst

Expose custom scheduler option in helm values
ClosedPublic
Actions

Authored by rexledesma on Sat, Jan 9, 12:06 AM.

Details

Reviewers

alangenfeld
nate
catherinewu

Commits

R1:7a08806301b1: Expose custom scheduler option in helm values

Summary

Addresses https://dagster.phacility.com/D4920#158742

Test Plan

bk
helm template

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rexledesma created this revision.Sat, Jan 9, 12:06 AM

rexledesma published this revision for review.Sat, Jan 9, 12:11 AM

Harbormaster failed remote builds in B23991: Diff 29174!Sat, Jan 9, 12:22 AM

rexledesma added a child revision: D5890: Expose custom run launcher option in helm values.Sat, Jan 9, 12:37 AM

rebase

Harbormaster completed remote builds in B24003: Diff 29188.Sat, Jan 9, 2:01 AM

rexledesma added inline comments.Mon, Jan 11, 4:54 PM

.yamllint.yaml
4	This was bringing a lot of pain... so disabled

alangenfeld accepted this revision.Mon, Jan 11, 10:06 PM

This revision is now accepted and ready to land.Mon, Jan 11, 10:06 PM

Closed by commit R1:7a08806301b1: Expose custom scheduler option in helm values (authored by rexledesma). · Explain WhyTue, Jan 12, 7:07 PM

This revision was automatically updated to reflect the committed changes.

rexledesma added a commit: R1:7a08806301b1: Expose custom scheduler option in helm values.

Revision Contents
Changeset List

Path

Size

.yamllint.yaml

1 line

helm/

dagster/

templates/

configmap-instance.yaml

4 lines

helpers/

instance/

_scheduler.tpl

7 lines

values.schema.json

56 lines

values.yaml

10 lines

python_modules/

automation/

helm/

schema/

subschema/

scheduler.py

16 lines

Diff 29396

View Options

.yamllint.yaml

View Options

helm/dagster/templates/configmap-instance.yaml

View Options

helm/dagster/templates/helpers/instance/_scheduler.tpl

View Options

helm/dagster/values.schema.json

View Options

helm/dagster/values.yaml

View Options

python_modules/automation/automation/helm/schema/subschema/scheduler.py

Expose custom scheduler option in helm valuesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29396

.yamllint.yaml

helm/dagster/templates/configmap-instance.yaml

helm/dagster/templates/helpers/instance/_scheduler.tpl

helm/dagster/values.schema.json

helm/dagster/values.yaml

python_modules/automation/automation/helm/schema/subschema/scheduler.py

Expose custom scheduler option in helm values
ClosedPublic
Actions

Revision Contents
Changeset List