Page MenuHomePhabricator
Differential D5882

object manager -> IO manager
ClosedPublic
Actions

Authored by sandyryza on Fri, Jan 8, 5:28 PM.

Details

Reviewers
cdecarolis
yuhan
schrockn
Commits
R1:adbc20020757: object manager -> IO manager
Summary

object manager -> IO manager

Test Plan

bk, built and reviewed docs site

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sandyryza created this revision.Fri, Jan 8, 5:28 PM
sandyryza updated this revision to Diff 29091.Fri, Jan 8, 5:41 PM

up

Harbormaster failed remote builds in B23927: Diff 29089!Fri, Jan 8, 5:47 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 5:57 PM
Harbormaster failed remote builds in B23929: Diff 29091!
sandyryza updated this revision to Diff 29098.Fri, Jan 8, 6:44 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 7:00 PM
Harbormaster failed remote builds in B23934: Diff 29098!
sandyryza updated this revision to Diff 29102.Fri, Jan 8, 7:25 PM

up

Harbormaster completed remote builds in B23938: Diff 29102.Fri, Jan 8, 7:44 PM
sandyryza requested review of this revision.Fri, Jan 8, 7:44 PM
yuhan added a comment.Fri, Jan 8, 7:51 PM

can still see "object manager" and "object_manager" in comments and migration guide, e.g. object_manager_from_intermediate_storage in migration. can we grep it and make sure all are captured

sandyryza updated this revision to Diff 29137.Fri, Jan 8, 10:09 PM

up

Harbormaster completed remote builds in B23968: Diff 29137.Fri, Jan 8, 10:27 PM
sandyryza updated this revision to Diff 29170.Fri, Jan 8, 11:40 PM

up

Harbormaster completed remote builds in B23989: Diff 29170.Fri, Jan 8, 11:58 PM
sandyryza added a comment.Sat, Jan 9, 12:57 AM

@yuhan thanks for catching those ones I missed. I went through and did another pass.. I think I got everything this time.

yuhan accepted this revision.Sat, Jan 9, 1:14 AM
This revision is now accepted and ready to land.Sat, Jan 9, 1:14 AM
sandyryza updated this revision to Diff 29187.Sat, Jan 9, 1:38 AM

up

Harbormaster failed remote builds in B24002: Diff 29187!Sat, Jan 9, 1:54 AM
sandyryza updated this revision to Diff 29194.Sat, Jan 9, 2:09 AM

up

Harbormaster failed remote builds in B24008: Diff 29194!Sat, Jan 9, 2:24 AM
sandyryza updated this revision to Diff 29213.Sat, Jan 9, 4:45 PM

up

Harbormaster failed remote builds in B24026: Diff 29213!Sat, Jan 9, 5:02 PM
sandyryza updated this revision to Diff 29215.Sat, Jan 9, 5:32 PM

up

Harbormaster completed remote builds in B24028: Diff 29215.Sat, Jan 9, 5:49 PM
Closed by commit R1:adbc20020757: object manager -> IO manager (authored by sandyryza). · Explain WhySat, Jan 9, 6:15 PM
This revision was automatically updated to reflect the committed changes.
sandyryza added a commit: R1:adbc20020757: object manager -> IO manager.

Large Diff

This large diff affects 117 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
20 lines
docs/
next/
public/
assets/
images/
overview/
io-managers/
object-managers/
io-managers.png
object-managers.png
object-managers/
src/
pages/
_apidocs/
2 lines
examples/
4 lines
overview/
asset-materializations/
8 lines
io-managers/
189 lines
object-managers/
8 lines
sections/
api/
apidocs/
2 lines
io-managers.rst
object-managers.rst
20 lines
libraries/
4 lines
4 lines
4 lines
examples/
basic_pyspark/
8 lines
docs_snippets/
docs_snippets/
overview/
asset_materializations/
6 lines
io_managers/
object_managers/
custom_io_manager.py
custom_object_manager.py
12 lines
io_manager_per_output.py
object_manager_per_output.py
13 lines
16 lines
16 lines
18 lines
io_managers/
16 lines
object_managers/
docs_snippets_tests/
overview_tests/
io_manager_tests/
5 lines
6 lines
11 lines
5 lines
io_manager_tests/
object_manager_tests/
test_io_manager_per_output.py
test_object_manager_per_output.py
4 lines
2 lines
2 lines
2 lines
object_manager_tests/
python_modules/
dagster-graphql/
dagster_graphql_tests/
graphql/
snapshots/
dagster/
dagster/
28 lines
core/
definitions/
20 lines
2 lines
6 lines
6 lines
2 lines
execution/
context/
8 lines
plan/
2 lines
8 lines
28 lines
8 lines
storage/
fs_io_manager.py
fs_object_manager.py
48 lines
4 lines
io_manager.py
object_manager.py
44 lines
mem_io_manager.py
mem_object_manager.py
12 lines
memoizable_io_manager.py
memoizable_object_manager.py
20 lines
22 lines
system_config/
4 lines
dagster_tests/
cli_tests/
command_tests/
2 lines
core_tests/
config_types_tests/
evaluator_tests/
20 lines
execution_tests/
12 lines
2 lines
snap_tests/
snapshots/
storage_tests/
test_fs_io_manager.py
test_fs_object_manager.py
12 lines
30 lines
test_io_manager.py
test_object_manager.py
134 lines
test_io_manager_backcompat.py
test_object_manager_backcompat.py
6 lines
test_io_manager_multiprocess.py
test_object_manager_multiprocess.py
8 lines
test_memoizable_io_manager.py
test_memoizable_object_manager.py
8 lines
18 lines
system_config_tests/
6 lines
2 lines
28 lines
libraries/
dagster-aws/
dagster_aws/
s3/
2 lines
io_manager.py
object_manager.py
20 lines
dagster_aws_tests/
s3_tests/
test_io_manager.py
test_object_manager.py
20 lines
dagster-azure/
dagster_azure/
adls2/
2 lines
io_manager.py
object_manager.py
18 lines
dagster_azure_tests/
adls2_tests/
test_io_manager.py
test_object_manager.py
28 lines
dagster-gcp/
dagster_gcp/
gcs/
2 lines
io_manager.py
object_manager.py
18 lines
dagster_gcp_tests/
gcs_tests/
test_io_manager.py
test_object_manager.py
20 lines
dagstermill/
dagstermill_tests/
2 lines

Diff 29221

View Options

docs/next/public/assets/images/overview/io-managers/io-managers.png

View Options

docs/next/public/assets/images/overview/io-managers/manager-venn-diagram.png

View Options

docs/next/public/assets/images/overview/object-managers/manager-venn-diagram.png

View Options

docs/next/public/assets/images/overview/object-managers/object-managers.png

View Options

docs/next/src/pages/_apidocs/index.mdx

View Options

docs/next/src/pages/examples/basic_pyspark.mdx

View Options

docs/next/src/pages/overview/asset-materializations/index.mdx

View Options

docs/next/src/pages/overview/io-managers/io-managers.mdx

View Options

docs/next/src/pages/overview/object-managers/object-managers.mdx

View Options

docs/next/src/treeOfContents.json

View Options

docs/sections/api/apidocs/execution.rst

View Options

docs/sections/api/apidocs/io-managers.rst

View Options

docs/sections/api/apidocs/libraries/dagster_aws.rst

View Options

docs/sections/api/apidocs/libraries/dagster_azure.rst

View Options

docs/sections/api/apidocs/libraries/dagster_gcp.rst

View Options

docs/sections/api/apidocs/object-managers.rst

View Options

examples/basic_pyspark/repo.py

View Options

examples/docs_snippets/docs_snippets/overview/asset_materializations/materialization_asset_stores.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/__init__.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/config_input_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/custom_io_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/default_io_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/io_manager_per_output.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/metadata.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/output_config.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/root_input_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/io_managers/subselection.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/__init__.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/config_input_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/custom_object_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/default_object_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/metadata.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/object_manager_per_output.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/output_config.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/root_input_manager.py

View Options

examples/docs_snippets/docs_snippets/overview/object_managers/subselection.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_config_input_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_custom_io_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_default_io_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_io_manager_per_output.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_metadata.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_output_config.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_root_input_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/io_manager_tests/test_subselection.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_config_input_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_custom_object_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_default_object_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_metadata.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_object_manager_per_output.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_output_config.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_root_input_manager.py

View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/object_manager_tests/test_subselection.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_all_snapshot_ids.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_pipeline_snapshot.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_resources.py

View Options

python_modules/dagster/dagster/__init__.py

View Options

python_modules/dagster/dagster/core/definitions/executor.py

View Options

python_modules/dagster/dagster/core/definitions/intermediate_storage.py

View Options

python_modules/dagster/dagster/core/definitions/mode.py

View Options

python_modules/dagster/dagster/core/definitions/output.py

View Options

python_modules/dagster/dagster/core/definitions/pipeline.py

View Options

python_modules/dagster/dagster/core/execution/context/system.py

View Options

python_modules/dagster/dagster/core/execution/plan/execute_step.py

View Options

python_modules/dagster/dagster/core/execution/plan/inputs.py

View Options

python_modules/dagster/dagster/core/execution/plan/plan.py

View Options

python_modules/dagster/dagster/core/execution/resolve_versions.py

View Options

python_modules/dagster/dagster/core/storage/fs_io_manager.py

View Options

python_modules/dagster/dagster/core/storage/fs_object_manager.py

View Options

python_modules/dagster/dagster/core/storage/intermediate_storage.py

View Options

python_modules/dagster/dagster/core/storage/io_manager.py

View Options

python_modules/dagster/dagster/core/storage/mem_io_manager.py

View Options

python_modules/dagster/dagster/core/storage/mem_object_manager.py

View Options

python_modules/dagster/dagster/core/storage/memoizable_io_manager.py

View Options

python_modules/dagster/dagster/core/storage/memoizable_object_manager.py

View Options

python_modules/dagster/dagster/core/storage/object_manager.py

View Options

python_modules/dagster/dagster/core/storage/system_storage.py

View Options

python_modules/dagster/dagster/core/system_config/objects.py

View Options

python_modules/dagster/dagster_tests/cli_tests/command_tests/test_memoized_development_cli.py

View Options

python_modules/dagster/dagster_tests/core_tests/config_types_tests/evaluator_tests/test_composite_descent.py

View Options

python_modules/dagster/dagster_tests/core_tests/execution_tests/memoized_dev_loop_pipeline.py

View Options

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_memoized_dev_loop.py

View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_active_data.py

View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_execution_plan.py

View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_mode_def_snap.py

View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_pipeline_snap.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_fs_io_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_fs_object_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_input_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_io_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_io_manager_backcompat.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_io_manager_multiprocess.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_memoizable_io_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_memoizable_object_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_object_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_object_manager_backcompat.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_object_manager_multiprocess.py

View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_output_manager.py

View Options

python_modules/dagster/dagster_tests/core_tests/system_config_tests/test_system_config.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_output_definition.py

View Options

python_modules/dagster/dagster_tests/core_tests/test_versioned_execution_plan.py

View Options

python_modules/libraries/dagster-aws/dagster_aws/s3/__init__.py

View Options

python_modules/libraries/dagster-aws/dagster_aws/s3/io_manager.py

View Options

python_modules/libraries/dagster-aws/dagster_aws/s3/object_manager.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_io_manager.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_object_manager.py

View Options

python_modules/libraries/dagster-azure/dagster_azure/adls2/__init__.py

View Options

python_modules/libraries/dagster-azure/dagster_azure/adls2/io_manager.py

View Options

python_modules/libraries/dagster-azure/dagster_azure/adls2/object_manager.py

View Options

python_modules/libraries/dagster-azure/dagster_azure_tests/adls2_tests/test_io_manager.py

View Options

python_modules/libraries/dagster-azure/dagster_azure_tests/adls2_tests/test_object_manager.py

View Options

python_modules/libraries/dagster-gcp/dagster_gcp/gcs/__init__.py

View Options

python_modules/libraries/dagster-gcp/dagster_gcp/gcs/io_manager.py

View Options

python_modules/libraries/dagster-gcp/dagster_gcp/gcs/object_manager.py

View Options

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_io_manager.py

View Options

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_object_manager.py

View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_manager.py