Consolidate helm image name template function
ClosedPublic
Actions

Authored by rexledesma on Jan 8 2021, 10:02 AM.

Details

Reviewers

• nate
• bob
alangenfeld

Commits

R1:f1bcad9be660: Consolidate helm image name template function

Summary

Depends on D5873

Validation for image repository/tag is not required since this is now done
by the helm schema. Here, we consolidate the formatting of image
repository and tag to one function.

Test Plan

integration

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rexledesma created this revision.Jan 8 2021, 10:02 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2021, 10:39 AM

Harbormaster failed remote builds in B23905: Diff 29059!

rebase

Harbormaster completed remote builds in B23917: Diff 29077.Jan 8 2021, 4:25 PM

rexledesma requested review of this revision.Jan 8 2021, 4:25 PM

rexledesma added reviewers: • nate, • bob, alangenfeld.Jan 8 2021, 4:43 PM

• nate accepted this revision.Jan 8 2021, 4:52 PM

This revision is now accepted and ready to land.Jan 8 2021, 4:52 PM

rexledesma edited the summary of this revision. (Show Details)Jan 8 2021, 6:07 PM

rexledesma added a parent revision: D5873: [2/2] Add helm schema for dagster run launcher.

Closed by commit R1:f1bcad9be660: Consolidate helm image name template function (authored by rexledesma). · Explain WhyJan 8 2021, 11:25 PM

This revision was automatically updated to reflect the committed changes.

rexledesma added a commit: R1:f1bcad9be660: Consolidate helm image name template function.

Revision Contents
Changeset List

Path

Size

helm/

dagster/

templates/

deployment-celery-queues.yaml

2 lines

deployment-dagit.yaml

2 lines

deployment-flower.yaml

2 lines

helpers/

_helpers.tpl

24 lines

instance/

_run-launcher.tpl

2 lines

_scheduler.tpl

2 lines

Diff 29167

View Options

helm/dagster/templates/deployment-celery-queues.yaml

View Options

helm/dagster/templates/deployment-dagit.yaml

View Options

helm/dagster/templates/deployment-flower.yaml

View Options

helm/dagster/templates/helpers/_helpers.tpl

View Options

helm/dagster/templates/helpers/instance/_run-launcher.tpl

View Options

helm/dagster/templates/helpers/instance/_scheduler.tpl

Consolidate helm image name template functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29167

helm/dagster/templates/deployment-celery-queues.yaml

helm/dagster/templates/deployment-dagit.yaml

helm/dagster/templates/deployment-flower.yaml

helm/dagster/templates/helpers/_helpers.tpl

helm/dagster/templates/helpers/instance/_run-launcher.tpl

helm/dagster/templates/helpers/instance/_scheduler.tpl

Consolidate helm image name template function
ClosedPublic
Actions

Revision Contents
Changeset List