Page MenuHomePhabricator
Differential D5872

[1/2] Add helm configuration for dagster run launcher
ClosedPublic
Actions

Authored by rexledesma on Fri, Jan 8, 1:11 AM.

Details

Reviewers
alangenfeld
nate
catherinewu
Commits
R1:f5c4ec5f20df: [1/2] Add helm configuration for dagster run launcher
Summary

Depends on D4920

We consolidate celery and k8sRunLauncher under one field:
runLauncher. Similar to D5745 and D4920, we use enum types
to switch between the two supported run launchers.

Test Plan

integration
diff the output of helm template before and after change

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rexledesma created this revision.Fri, Jan 8, 1:11 AM
rexledesma added a child revision: D5873: [2/2] Add helm schema for dagster run launcher.Fri, Jan 8, 1:22 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 1:27 AM
Harbormaster failed remote builds in B23891: Diff 29045!
rexledesma updated this revision to Diff 29048.Fri, Jan 8, 1:29 AM

isort

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 2:05 AM
Harbormaster failed remote builds in B23894: Diff 29048!
rexledesma updated this revision to Diff 29057.Fri, Jan 8, 9:45 AM

fix integration tests

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 10:24 AM
Harbormaster failed remote builds in B23903: Diff 29057!
rexledesma updated this revision to Diff 29060.Fri, Jan 8, 10:41 AM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 11:21 AM
Harbormaster failed remote builds in B23906: Diff 29060!
rexledesma updated this revision to Diff 29069.Fri, Jan 8, 3:39 PM

up

Harbormaster completed remote builds in B23912: Diff 29069.Fri, Jan 8, 3:58 PM
rexledesma requested review of this revision.Fri, Jan 8, 3:58 PM
rexledesma added reviewers: alangenfeld, nate, catherinewu.Fri, Jan 8, 4:04 PM
rexledesma added a child revision: Restricted Differential Revision.Fri, Jan 8, 5:01 PM
rexledesma edited the summary of this revision. (Show Details)Fri, Jan 8, 6:08 PM
rexledesma added a parent revision: D4920: Update Scheduler helm schema to use enum types.
alangenfeld accepted this revision.Fri, Jan 8, 10:49 PM

i take it the new defaults will be in a followup diff?

helm/dagster/values.yaml
267

don't we want to default to k8srunlauncher?

406

and this false?

This revision is now accepted and ready to land.Fri, Jan 8, 10:49 PM
Closed by commit R1:f5c4ec5f20df: [1/2] Add helm configuration for dagster run launcher (authored by rexledesma). · Explain WhyFri, Jan 8, 11:24 PM
This revision was automatically updated to reflect the committed changes.
rexledesma added a commit: R1:f5c4ec5f20df: [1/2] Add helm configuration for dagster run launcher.

Revision Contents
Changeset List

PathSize
2 lines
1 line
9 lines
helm/
dagster/
templates/
15 lines
12 lines
54 lines
59 lines
helpers/
31 lines
instance/
63 lines
2 lines
204 lines
integration_tests/
python_modules/
dagster-k8s-test-infra/
dagster_k8s_test_infra/
126 lines
python_modules/
automation/
automation/
helm/
schema/
subschema/
2 lines

Diff 29165

View Options

.yamllint.yaml

Loading...
View Options

CHANGES.md

Loading...
View Options

MIGRATION.md

Loading...
View Options

helm/dagster/templates/configmap-celery.yaml

Loading...
View Options

helm/dagster/templates/configmap-env-celery.yaml

Loading...
View Options

helm/dagster/templates/configmap-instance.yaml

Loading...
View Options

helm/dagster/templates/deployment-celery-queues.yaml

Loading...
View Options

helm/dagster/templates/helpers/_helpers.tpl

Loading...
View Options

helm/dagster/templates/helpers/instance/_run-launcher.tpl

Loading...
View Options

helm/dagster/templates/helpers/instance/_scheduler.tpl

Loading...
View Options

helm/dagster/values.yaml

Loading...
View Options

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

Loading...
View Options

python_modules/automation/automation/helm/schema/subschema/__init__.py

Loading...