Details

Reviewers

alangenfeld
• nate
• catherinewu

Commits

R1:f5c4ec5f20df: [1/2] Add helm configuration for dagster run launcher

Summary

Depends on D4920

We consolidate celery and k8sRunLauncher under one field:
runLauncher. Similar to D5745 and D4920, we use enum types
to switch between the two supported run launchers.

Test Plan

integration
diff the output of helm template before and after change

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rexledesma created this revision.Jan 8 2021, 1:11 AM

rexledesma added a child revision: D5873: [2/2] Add helm schema for dagster run launcher.Jan 8 2021, 1:22 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2021, 1:27 AM

Harbormaster failed remote builds in B23891: Diff 29045!

isort

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2021, 2:05 AM

Harbormaster failed remote builds in B23894: Diff 29048!

fix integration tests

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2021, 10:24 AM

Harbormaster failed remote builds in B23903: Diff 29057!

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 8 2021, 11:21 AM

Harbormaster failed remote builds in B23906: Diff 29060!

Harbormaster completed remote builds in B23912: Diff 29069.Jan 8 2021, 3:58 PM

rexledesma requested review of this revision.Jan 8 2021, 3:58 PM

rexledesma added reviewers: alangenfeld, • nate, • catherinewu.Jan 8 2021, 4:04 PM

rexledesma added a child revision: Restricted Differential Revision.Jan 8 2021, 5:01 PM

rexledesma edited the summary of this revision. (Show Details)Jan 8 2021, 6:08 PM

rexledesma added a parent revision: D4920: Update Scheduler helm schema to use enum types.

i take it the new defaults will be in a followup diff?

helm/dagster/values.yaml
268	don't we want to default to k8srunlauncher?
406	and this false?

This revision is now accepted and ready to land.Jan 8 2021, 10:49 PM

Closed by commit R1:f5c4ec5f20df: [1/2] Add helm configuration for dagster run launcher (authored by rexledesma). · Explain WhyJan 8 2021, 11:24 PM

This revision was automatically updated to reflect the committed changes.

rexledesma added a commit: R1:f5c4ec5f20df: [1/2] Add helm configuration for dagster run launcher.

[1/2] Add helm configuration for dagster run launcher
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 29165

.yamllint.yaml

CHANGES.md

MIGRATION.md

helm/dagster/templates/configmap-celery.yaml

helm/dagster/templates/configmap-env-celery.yaml

helm/dagster/templates/configmap-instance.yaml

helm/dagster/templates/deployment-celery-queues.yaml

helm/dagster/templates/helpers/_helpers.tpl

helm/dagster/templates/helpers/instance/_run-launcher.tpl

helm/dagster/templates/helpers/instance/_scheduler.tpl

helm/dagster/values.yaml

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

python_modules/automation/automation/helm/schema/subschema/init.py

[1/2] Add helm configuration for dagster run launcherClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29165

.yamllint.yaml

CHANGES.md

MIGRATION.md

helm/dagster/templates/configmap-celery.yaml

helm/dagster/templates/configmap-env-celery.yaml

helm/dagster/templates/configmap-instance.yaml

helm/dagster/templates/deployment-celery-queues.yaml

helm/dagster/templates/helpers/_helpers.tpl

helm/dagster/templates/helpers/instance/_run-launcher.tpl

helm/dagster/templates/helpers/instance/_scheduler.tpl

helm/dagster/values.yaml

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

python_modules/automation/automation/helm/schema/subschema/__init__.py

[1/2] Add helm configuration for dagster run launcher
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/automation/automation/helm/schema/subschema/init.py