Page MenuHomePhabricator

[1/2] Add helm configuration for dagster run launcher
ClosedPublic

Authored by rexledesma on Fri, Jan 8, 1:11 AM.

Details

Summary

Depends on D4920

We consolidate celery and k8sRunLauncher under one field:
runLauncher. Similar to D5745 and D4920, we use enum types
to switch between the two supported run launchers.

Test Plan

integration
diff the output of helm template before and after change

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 1:27 AM
Harbormaster failed remote builds in B23891: Diff 29045!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 2:05 AM
Harbormaster failed remote builds in B23894: Diff 29048!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 10:24 AM
Harbormaster failed remote builds in B23903: Diff 29057!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jan 8, 11:21 AM
Harbormaster failed remote builds in B23906: Diff 29060!
rexledesma added a child revision: Restricted Differential Revision.Fri, Jan 8, 5:01 PM

i take it the new defaults will be in a followup diff?

helm/dagster/values.yaml
267

don't we want to default to k8srunlauncher?

406

and this false?

This revision is now accepted and ready to land.Fri, Jan 8, 10:49 PM