Page MenuHomePhabricator

AssetStoreOperation.serializable
ClosedPublic

Authored by yuhan on Thu, Jan 7, 8:27 PM.

Details

Summary

stopgap for the diffs later in the stack. will drop AssetStoreOperation soon tho

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuhan requested review of this revision.Thu, Jan 7, 9:01 PM

If I understand correctly, the normal path converts to AssetStoreOperation to AssetStoreOperationData, which already is serializable?

@sandyryza yes but the problem here is in AssetStoreOperationType which will need to be converted to .value to be able to serialize

This revision is now accepted and ready to land.Thu, Jan 7, 9:13 PM
This revision was automatically updated to reflect the committed changes.