Page MenuHomePhabricator
Differential D5858

Update instance docs to reflect 0.10.0 changes
ClosedPublic
Actions

Authored by dgibson on Thu, Jan 7, 6:57 PM.

Details

Reviewers
johann
prha
schrockn
alangenfeld
sashank
Commits
R1:e8f058eb7dd3: Update instance docs to reflect 0.10.0 changes
Summary
  • Reference DagsterDaemonSCheduler, the run coordinator, remove deprecated info about the scheduler, tweak some copy
Test Plan

View docs, check each link

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dgibson created this revision.Thu, Jan 7, 6:57 PM
dgibson published this revision for review.Thu, Jan 7, 6:59 PM
dgibson added a reviewer: sashank.
Harbormaster failed remote builds in B23829: Diff 28970!Thu, Jan 7, 7:17 PM
dgibson updated this revision to Diff 28987.Thu, Jan 7, 8:21 PM

update example instance yaml

Harbormaster failed remote builds in B23844: Diff 28987!Thu, Jan 7, 8:38 PM
dgibson updated this revision to Diff 29035.Thu, Jan 7, 11:29 PM

up

Harbormaster failed remote builds in B23882: Diff 29035!Thu, Jan 7, 11:43 PM
schrockn requested changes to this revision.Fri, Jan 8, 12:59 PM
schrockn added a subscriber: sandyryza.
schrockn added inline comments.
docs/next/src/pages/overview/instances/dagster-instance.mdx
58–59

Chat with @sandyryza and co about how this part should be messaged in an IOManager world

This revision now requires changes to proceed.Fri, Jan 8, 12:59 PM
dgibson requested review of this revision.Fri, Jan 8, 9:09 PM
dgibson added a subscriber: yuhan.

checked in with @yuhan who is going to do a separate pass on the docs to scrub intermediates

dgibson updated this revision to Diff 29128.Fri, Jan 8, 9:10 PM

up

yuhan added inline comments.Fri, Jan 8, 9:12 PM
docs/next/src/pages/overview/instances/dagster-instance.mdx
58–59

feel free to leave it out from this diff. will do a full pass to clean up intermediate docs mentioning
tracking issue here: https://github.com/dagster-io/dagster/issues/3516

Harbormaster failed remote builds in B23962: Diff 29128!Fri, Jan 8, 9:25 PM
schrockn accepted this revision.Fri, Jan 8, 10:41 PM

startreknod

This revision is now accepted and ready to land.Fri, Jan 8, 10:41 PM
dgibson updated this revision to Diff 29269.Mon, Jan 11, 4:49 PM

up

dgibson updated this revision to Diff 29271.Mon, Jan 11, 4:54 PM

up

Harbormaster failed remote builds in B24074: Diff 29269!Mon, Jan 11, 5:04 PM
Harbormaster completed remote builds in B24076: Diff 29271.Mon, Jan 11, 5:12 PM
Closed by commit R1:e8f058eb7dd3: Update instance docs to reflect 0.10.0 changes (authored by dgibson). · Explain WhyMon, Jan 11, 5:22 PM
This revision was automatically updated to reflect the committed changes.
dgibson added a commit: R1:e8f058eb7dd3: Update instance docs to reflect 0.10.0 changes.

Revision Contents
Changeset List

PathSize
docs/
next/
src/
pages/
overview/
instances/
55 lines
sections/
api/
apidocs/
12 lines
6 lines
examples/
docs_snippets/
docs_snippets/
overview/
instances/
19 lines
docs_snippets_tests/
overview_tests/
instances_tests/
1 line
python_modules/
dagster/
dagster/
core/
scheduler/
2 lines

Diff 29279

View Options

docs/next/src/pages/overview/instances/dagster-instance.mdx

Loading...
View Options

docs/sections/api/apidocs/internals.rst

Loading...
View Options

docs/sections/api/apidocs/schedules-sensors.rst

Loading...
View Options

examples/docs_snippets/docs_snippets/overview/instances/dagster.yaml

Loading...
View Options

examples/docs_snippets/docs_snippets_tests/overview_tests/instances_tests/test_yaml.py

Loading...
View Options

python_modules/dagster/dagster/core/scheduler/scheduler.py

Loading...