Page MenuHomePhabricator

[dagit] Make sections of Instance config page linkable
ClosedPublic

Authored by dish on Jan 7 2021, 5:33 PM.

Details

Summary

Enable linking to specific sections of yaml in the configuration section of "Instance details". We can use this to direct users to their configuration settings from elsewhere in Dagit, e.g. schedules.

For each top-level config section, there is a link that uses a hash to jump to that section. The hash-identified section will be highlighted in light gray. If no hash (or a missing hash) is used, nothing is highlighted.

Test Plan

View /instance/config, verify correct rendering of yaml sections. Use link icon to highlight a section. Reload the page with that hash in place on the URL, verify that the browser jumps to it.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This comment was removed by dish.
dish requested review of this revision.Jan 7 2021, 5:40 PM

Wow this is a cool idea, code looks good to me! I like the highlighted styling too, nice UI bonus ๐Ÿ™Œ

This revision is now accepted and ready to land.Jan 8 2021, 4:35 AM