Page MenuHomePhabricator
Differential D5852

mypy everything (almost)
ClosedPublic
Actions

Authored by sandyryza on Wed, Jan 6, 9:50 PM.

Details

Reviewers
max
schrockn
Commits
R1:4c721ea7b5c4: mypy everything (almost)
Summary

This adds type-checking for all dagster packages that don't currently have type-checking issues.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sandyryza created this revision.Wed, Jan 6, 9:50 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 6, 10:08 PM
Harbormaster failed remote builds in B23777: Diff 28914!
sandyryza updated this revision to Diff 28927.Wed, Jan 6, 11:04 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 6, 11:21 PM
Harbormaster failed remote builds in B23786: Diff 28927!
sandyryza retitled this revision from mypy everything to mypy (almost) everything.Wed, Jan 6, 11:27 PM
sandyryza updated this revision to Diff 28929.Wed, Jan 6, 11:27 PM
sandyryza retitled this revision from mypy (almost) everything to mypy everything.

up

sandyryza retitled this revision from mypy everything to mypy everything (almost).Wed, Jan 6, 11:28 PM
sandyryza edited the summary of this revision. (Show Details)
sandyryza added a reviewer: schrockn.
Harbormaster completed remote builds in B23788: Diff 28929.Wed, Jan 6, 11:45 PM
sandyryza requested review of this revision.Wed, Jan 6, 11:45 PM
schrockn resigned from this revision.Thu, Jan 7, 3:23 PM

will let you guys handle this

max accepted this revision.Tue, Jan 12, 4:52 PM
This revision is now accepted and ready to land.Tue, Jan 12, 4:52 PM
sandyryza updated this revision to Diff 29406.Tue, Jan 12, 7:27 PM

up

Harbormaster completed remote builds in B24174: Diff 29406.Tue, Jan 12, 7:48 PM
Closed by commit R1:4c721ea7b5c4: mypy everything (almost) (authored by sandyryza). · Explain WhyTue, Jan 12, 9:17 PM
This revision was automatically updated to reflect the committed changes.
sandyryza added a commit: R1:4c721ea7b5c4: mypy everything (almost).

Revision Contents
Changeset List

PathSize
.buildkite/
dagster-buildkite/
dagster_buildkite/
51 lines

Diff 29425

View Options

.buildkite/dagster-buildkite/dagster_buildkite/module_build_spec.py

Loading...