Page MenuHomePhabricator

Add expectations pipeline with histograms
AbandonedPublic

Authored by max on Jul 10 2019, 11:36 PM.

Details

Reviewers
schrockn
bengotow
Summary

Test pipeline for histogram display

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
histogram-expectations
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Jul 10 2019, 11:36 PM
schrockn accepted this revision.Jul 10 2019, 11:54 PM
schrockn added inline comments.
examples/dagster_examples/toys/expectations.py
9

yeah we're going to just want to be able to send down arbitrary metadata chunks once this is working eh

python_modules/dagster/dagster/core/definitions/events.py
19

thanks

This revision is now accepted and ready to land.Jul 10 2019, 11:54 PM
max marked an inline comment as done.Jul 10 2019, 11:58 PM
max added inline comments.
examples/dagster_examples/toys/expectations.py
9

yes, this API is a little clunky

actually just meant to comment not accept. oh well

schrockn requested changes to this revision.Jul 11 2019, 12:01 AM

If there is going to be specialized rendering for the histogram there should be a specialized type for it in the EntryDataUnion

This revision now requires changes to proceed.Jul 11 2019, 12:01 AM
max updated this revision to Diff 2739.Jul 11 2019, 12:21 AM

Specialize type

I think we should hold off on committing until we can do an end-to-end prototype.

python_modules/dagster-graphql/dagster_graphql/schema/runs.py
284

we'd want to make this more strongly typed for sure

max updated this revision to Diff 2756.Jul 11 2019, 5:54 PM

Fix arg order

max updated this revision to Diff 2762.Jul 11 2019, 8:09 PM

Fix tuple order

max updated this revision to Diff 2767.Jul 11 2019, 8:27 PM

Fix order

max updated this revision to Diff 2801.Jul 12 2019, 12:09 AM

Fixup

schrockn requested changes to this revision.Jul 29 2019, 10:00 PM

bouncing back to you

This revision now requires changes to proceed.Jul 29 2019, 10:00 PM
max abandoned this revision.Aug 13 2019, 11:14 PM