While looking into #3503 I noticed an Apollo warning about PartitionSet needing an id field for better caching. This adds it, just duplicating the name field.
generally i think this makes snese, just suggest doign it based on the pipeline rather than the repo
return ExternalPartitionSetOrigin( self.repository_handle.get_external_origin().get_pipeline_origin( self.pipeline_name ), self.partition_set.name)
can remove this, see above
this should probably take in an external_pipeline_origin or a repo origin instead, to reflect the fact that (I think) it only needs to be unique per-pipeline, unlike schedules
you can remove this
including an 'id' field on GET_PARTITION_SET_STATUS_QUERY in test_partition_sets.py would be cool too just to make sure the new code gets exercised in tests - don't necc. need to verify the value of the result that comes out although that would be even better