2] pass through resources to context of input and output managers
ClosedPublic
Actions

Authored by cdecarolis on Wed, Jan 6, 3:38 PM.

Details

Reviewers

sandyryza
yuhan

Commits

R1:fbe2f3d1b219: [i/o manager cleanup 1/2] pass through resources to context of input and output…

Summary

This passes resources through to input and output context.

Test Plan

unit tests

Diff Detail

Repository

R1 dagster

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cdecarolis created this revision.Wed, Jan 6, 3:38 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 6, 3:54 PM

Harbormaster failed remote builds in B23717: Diff 28841!

Harbormaster completed remote builds in B23725: Diff 28851.Wed, Jan 6, 4:59 PM

cdecarolis requested review of this revision.Wed, Jan 6, 4:59 PM

Harbormaster completed remote builds in B23733: Diff 28862.Wed, Jan 6, 5:32 PM

cdecarolis retitled this revision from pass through resources to context of input and output managers to [i/o manager cleanup 1/2] pass through resources to context of input and output managers.Wed, Jan 6, 8:18 PM

how would one mock the input/output context with the scoped resources?

In D5836#157697, @yuhan wrote:

how would one mock the input/output context with the scoped resources?

So if you aren't using any resources, you won't need to mock them, you can just leave them uninitialized. If you are using resources, since ScopedResources is just a namedtuple constructed from the passed in resource dict, you could mock out the resources by doing something like mock.MagicMock(resource1=..., resource2=...,etc)

sandyryza accepted this revision.Thu, Jan 7, 4:28 PM

This revision is now accepted and ready to land.Thu, Jan 7, 4:28 PM

Closed by commit R1:fbe2f3d1b219: [i/o manager cleanup 1/2] pass through resources to context of input and output… (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyThu, Jan 7, 10:15 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:fbe2f3d1b219: [i/o manager cleanup 1/2] pass through resources to context of input and output….