Page MenuHomePhabricator

[i/o manager cleanup 1/2] pass through resources to context of input and output managers
ClosedPublic

Authored by cdecarolis on Wed, Jan 6, 3:38 PM.

Details

Summary

This passes resources through to input and output context.

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Jan 6, 3:54 PM
Harbormaster failed remote builds in B23717: Diff 28841!
cdecarolis retitled this revision from pass through resources to context of input and output managers to [i/o manager cleanup 1/2] pass through resources to context of input and output managers.Wed, Jan 6, 8:18 PM

how would one mock the input/output context with the scoped resources?

In D5836#157697, @yuhan wrote:

how would one mock the input/output context with the scoped resources?

So if you aren't using any resources, you won't need to mock them, you can just leave them uninitialized. If you are using resources, since ScopedResources is just a namedtuple constructed from the passed in resource dict, you could mock out the resources by doing something like mock.MagicMock(resource1=..., resource2=...,etc)

This revision is now accepted and ready to land.Thu, Jan 7, 4:28 PM